no-fallthrough

A case that doesn't end with break, return, throw, continue or process.exit() keeps going into the code of the next case. A forgotten break runs code for a value it wasn't written for, and nothing fails at that line.

If you want the fallthrough, say so in a comment right before the next case. // falls through, // fall-through, // fallthrough and // no break all work, in any case. Several case labels in a row that share one body are allowed.

This rule is on by default.

Configure#

On by default as an error. To turn it off:

[lint.rules]
"no-fallthrough" = "off" # or "warn"

Every option, set to its default:

[lint.rules]
"no-fallthrough" = ["error", {
  commentPattern = "(?i:falls?[\\s-]?through|no\\s?break)",
  allowEmptyCase = false,
  reportUnusedFallthroughComment = false,
}]

Examples#

switch (post.status) {
  case "draft":
    publish(post);
  case "published":
    notify(post);
    break;
}

switch (post.status) {
  case "draft":
    publish(post);
    break;
  case "published":
    notify(post);
    break;
}

process.exit() and process.abort() end a case too. With --type-aware, so does any call that returns never. With an ESLint config file they don't, as in ESLint.

switch (command) {
  case "help":
    printUsage();
    process.exit(0);
  case "version":
    console.log(version);
    break;
}

switch (post.status) {
  case "draft":
    publish(post);
  // falls through
  case "published":
  case "pinned":
    notify(post);
    break;
}

switch (post.status) {
  case "draft":
    publish(post);
  /* intentional fall-through */
  case "published":
    notify(post);
  // no break
  default:
    log(post);
}

Options#

The default commentPattern is (?i:falls?[\s-]?through|no\s?break). With an ESLint config file it's ESLint's own, falls?\s?through in any case, which doesn't accept fall-through or no break.

switch (post.status) {
  case "draft":
    publish(post);
  // break omitted on purpose
  case "published":
    notify(post);
}

An empty case followed by a blank line looks like its body was deleted, so it's reported unless you set allowEmptyCase:

switch (post.status) {
  case "draft":

  case "published":
    notify(post);
}

switch (post.status) {
  case "draft":

  case "published":
    notify(post);
}

With reportUnusedFallthroughComment, a comment that's no longer true is reported:

switch (post.status) {
  case "draft":
    publish(post);
    break;
  // falls through
  case "published":
    notify(post);
}